Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patch-item): hide universal patches if not enabled #1087

Merged
merged 3 commits into from
Aug 5, 2023
Merged

fix(patch-item): hide universal patches if not enabled #1087

merged 3 commits into from
Aug 5, 2023

Conversation

TheAabedKhan
Copy link
Member

Fixes #1080

@TheAabedKhan TheAabedKhan linked an issue Aug 4, 2023 that may be closed by this pull request
bug: universal patches are always shown #1080
Closed
4 tasks
@Ushie
Copy link
Member

Ushie commented Aug 4, 2023

Also, what do you think about separating them into different sections? So scrolling to the bottom would display the universal patches section

@TheAabedKhan
Copy link
Member Author

Also, what do you think about separating them into different sections? So scrolling to the bottom would display the universal patches section

It can help achieve better UX when selecting patches. Will create a new PR for this.

@TheAabedKhan TheAabedKhan mentioned this pull request Aug 5, 2023
Closed
4 tasks
validcube
validcube requested changes Aug 5, 2023
View reviewed changes
Copy link
Member

@validcube validcube left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but the patch count in the app selector will not display correctly and this can cause confusion.

The patch count will still display (example) 60 patches instead of 52 patches regardless if the setting is disabled.

validcube
validcube approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@validcube validcube left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫 Changes have been tested and approved.

@validcube validcube merged commit 5346f6e into ReVanced:dev Aug 5, 2023
2 checks passed
@TheAabedKhan TheAabedKhan deleted the hide-universal branch October 12, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@validcube validcube validcube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: universal patches are always shown
3 participants
@TheAabedKhan @Ushie @validcube